[Not a full review, just some questions and an observation.]
Shouldn't new perl modules be building for 5.10 instead of 5.8.4 now?
Why do you deliver the _des.c & .h source files into /usr/demo?
It would be really nice if this module could use one of the many existing
DES implementations on Solaris instead of shipping yet another, but changing
that would pretty much replace all the upstream source code, so I guess is
outside the realm of a simple port.
-Alan Coopersmith- alan.coopersmith at sun.com
Sun Microsystems, Inc. - X Window System Engineering
Spoorthy H.S wrote:
> Hi,
> Please review. The new webrev is at
> http://cr.opensolaris.org/~spoorthy/ws_cryptdes3/
>
> Thanks
> Spoorthy
>
> -------- Original Message --------
> Subject: [sfwnv-discuss] Code review request for perl_crypt_des
> Date: Thu, 03 Sep 2009 15:56:59 +0530
> From: Spoorthy H.S <Spoorthy.Shankarmurthy at Sun.COM>
> Organization: Sun Microsystems India
> To: SFW-NV Discuss <sfwnv-discuss at opensolaris.org>
>
>
>
> Hi,
>
> I am porting the package Crypt-DES. This is the dependent package for
> Crypt-CBC. The information about the package can be found at
> http://search.cpan.org/dist/Crypt-DES/
> The webrev is at http://cr.opensolaris.org/~spoorthy/ws_cryptdes1/. Can
> somebody have a look at this and review the same.
>
> Thanks
> Spoorthy
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
