Sergio Gutierrez wrote:
> Hello sirs.
>
> I would like to ask a code review for the diff will solve bug 6605991:
> su(1) should print clearer error messages when it can't execute a user's
> shell
>
> Attached is the diff.
>
> My code contributor is OS0133, and sponsor for this fix is Eng. Viswa
> Kannapan.
>
> Thanks in advance for your attention.
>
> --
> Sergio Guti?rrez
I realize you implemented exactly what the bug submitter requested, but
I'm not convinced that it's a good idea to select one or two of the
possible error codes and make up new error messages for them.
I agree that it's a good idea to have a message that indicates which
error occurred (instead of "No shell" for all errors), but I would use
the system-defined message via either perror() or strerror().
Scott
--
Scott Rotondo
Senior Principal Engineer, Solaris Engineering
President, Trusted Computing Group
Phone/FAX: +1 408 850 3655 (Internal x68278)
