On Fri, Nov 04, 2005 at 02:02:08PM -0800, Thomas Milne wrote:
> I just started playing with Selenium this week, and I'm pretty excited 
> about it (if you listened to Luke Closs's selenium podcast on 
> qapodcast.com, I was the QA engineer he quoted near the end).
> 
> I've recently run into an issue where using Selenium to click a button 
> where onclick="Widget(this).nextCard()" causes Selenium to hang with the 
> Javascript error "element.parentNode has no properties". It looks like 
> something in Selenium is changing the value of 'this'- could anyone 
> point me in the right direction of what needs to be changed in order to 
> fix it? Or if it's fairly simple and somebody wants to have a crack at 
> patching it we'd love to test it for you!

Someone on my team managed to track this issue down.  The patch to fix
our problem is:

==== selenium-browserbot.js#1 - selenium-browserbot.js //====
@@ -728,7 +728,7 @@
         if (element.href) {
             this.currentWindow.location.href = element.href;
         }
-        else if (element.parentNode.href) {
+        else if (element.parentNode && element.parentNode.href) {
             this.currentWindow.location.href = element.parentNode.href;
         }
     }


I don't think that Tom created an official selenium bug on this.

Should I:

 - file a proper selenium bug and add the patch there
 - relax as someone else patches selenium with the above fix
 - get svn access and fix this myself

Your input is appreciated...

Luke


-- 
Luke Closs
PureMessage Developer 
There is always time to juggle in the Sophos Zone.
_______________________________________________
Selenium-devel mailing list
Selenium-devel@lists.public.thoughtworks.org
http://lists.public.thoughtworks.org/mailman/listinfo/selenium-devel

Reply via email to