Hi Peter, Thank you for the patch! Yet something to improve:
[auto build test ERROR on pcmoore-selinux/next] [also build test ERROR on v4.17-rc7] [cannot apply to security/next next-20180531] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Peter-Enderborg/selinux-Make-allocation-atomic-in-policydb-objects-functions/20180601-205558 base: https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git next config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=sh All error/warnings (new ones prefixed by >>): security/selinux/ss/policydb.c: In function 'policydb_flattened_alloc': >> security/selinux/ss/policydb.c:3544:12: error: implicit declaration of >> function 'vmalloc'; did you mean 'kvmalloc'? >> [-Werror=implicit-function-declaration] *tmpbuf = vmalloc(*size); ^~~~~~~ kvmalloc >> security/selinux/ss/policydb.c:3544:10: warning: assignment makes pointer >> from integer without a cast [-Wint-conversion] *tmpbuf = vmalloc(*size); ^ In file included from include/linux/printk.h:7:0, from include/linux/kernel.h:14, from security/selinux/ss/policydb.c:33: include/linux/kern_levels.h:5:18: warning: format '%ld' expects argument of type 'long int', but argument 2 has type 'size_t {aka unsigned int}' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^ include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH' #define KERN_ERR KERN_SOH "3" /* error conditions */ ^~~~~~~~ security/selinux/ss/policydb.c:3548:10: note: in expansion of macro 'KERN_ERR' printk(KERN_ERR "SELinux: vmalloc failed for %ld\n", *size); ^~~~~~~~ security/selinux/ss/policydb.c:3548:50: note: format string is defined here printk(KERN_ERR "SELinux: vmalloc failed for %ld\n", *size); ~~^ %d security/selinux/ss/policydb.c: In function 'policydb_flattened_free': >> security/selinux/ss/policydb.c:3555:2: error: implicit declaration of >> function 'vfree'; did you mean 'kvfree'? >> [-Werror=implicit-function-declaration] vfree(tmpbuf); ^~~~~ kvfree cc1: some warnings being treated as errors vim +3544 security/selinux/ss/policydb.c 3538 3539 int policydb_flattened_alloc(struct policydb *db, void **tmpbuf, size_t *size) 3540 { 3541 int rc = 0; 3542 3543 *size = db->len; > 3544 *tmpbuf = vmalloc(*size); 3545 3546 if (!*tmpbuf) { 3547 rc = -ENOMEM; > 3548 printk(KERN_ERR "SELinux: vmalloc failed for %ld\n", > *size); 3549 } 3550 return rc; 3551 } 3552 3553 int policydb_flattened_free(void *tmpbuf) 3554 { > 3555 vfree(tmpbuf); 3556 return 0; 3557 } 3558 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
_______________________________________________ Selinux mailing list Selinux@tycho.nsa.gov To unsubscribe, send email to selinux-le...@tycho.nsa.gov. To get help, send an email containing "help" to selinux-requ...@tycho.nsa.gov.
