On Thursday 08 March 2007 20:48, S Page wrote: > Thanks for your reply. > I tracked it down some more. As I updated the bug, I think this broke > in revision 17529 when normalizeRedirects() switched from working on > article names to working on Title objects. The function uses array_diff > with an empty array, I think to remove duplicates, but this casts to > string when comparing array entries, and this fails for MediaWiki's > Title objects. > > > I will soon rewrite the Inline Query code to separate parsing > > and query execution. If this does not fix the bug, it will at least > > make it > > > easier to track it down. > > OK then. I think the fix here is to rewrite this routine to work with > an array of article_ids. > > > I have a general question: isn't > $check_list = array_unique($list); // Copies the array without > duplicate values > > a better idiom than > $check_list = array_diff( $list, array() ); // Copies the array
Probably yes, though I do not know now whether duplicates can occur in this place. I think there are even copy constructors for arrays in PHP? Best, Markus > > ? > > Regards, > -- > =S -- Markus Krötzsch Institute AIFB, University of Karlsruhe, D-76128 Karlsruhe [EMAIL PROTECTED] phone +49 (0)721 608 7362 www.aifb.uni-karlsruhe.de/WBS/ fax +49 (0)721 693 717
pgpVzzf5XYscy.pgp
Description: PGP signature
------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________ Semediawiki-devel mailing list Semediawiki-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/semediawiki-devel
