On Montag, 10. August 2009, Temlakos wrote: > Dear Markus and Fabian, > > The attached patch, when applied to the file SMW_DV_Time.php, will > accomplish three things:
Great. Patch applied and committed to SVN. > > 1. Correct the processing of time offsets. Before the patch, time > offsets were being misapplied. This created a great deal of confusion. I wished more people would file bugs ... I am sure this could have been fixed with the previous release. > > 2. Add recognition of civilian time-zone monikers like GMT, UTC, WET, > CET, EET, MSZ, MSK, MSD--or, in the United States, EST, CST, MST, PST, > AKST, HAST, /et cetera/. This is very nice indeed. I wonder if people will start entering timezones in wikis. My guess is that most will still ignore this and silently assume that the "obvious" timezone applies. Should we have some configuration parameter to set a default timezone that is to be used? > > 3. Add recognition of US military times. A US military time /must/ be > followed by a capital letter (other than J for Juliet). I wonder whether there is a demand for this, but I added it nonetheless. It does not seem to complicate the code much. > > I had previously sent you an e-mail containing the code, but no good > automatic way to apply the code to the file. I created this patch with > the diff command, using options -a (enforced line-by-line comparison) > and -u (unified output). This is actually my first attempt to create a > patch file, so please let me know whether you can apply it or not. Yes, the patch worked well (only one minor issue due to an update that had happened since the patch was generated; easy enough to fix manually). Thanks, Markus -- Markus Krötzsch <mar...@semantic-mediawiki.org> * Personal page: http://korrekt.org * Semantic MediaWiki: http://semantic-mediawiki.org * Semantic Web textbook: http://semantic-web-book.org
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________ Semediawiki-devel mailing list Semediawiki-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/semediawiki-devel
