On Montag, 7. Juni 2010, Yaron Koren wrote:
> That one's already fixed in SVN:
> 
> http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/SemanticMediaWik
> i/includes/SMW_DataValue.php?r1=67090&r2=67279

Actually, this is still only a partial fix, though it might cover all current 
cases in SMW (extensions). The correct code in SMW 1.5.0 had a proper range 
check. It got removed when some intermediate changes that were included for 
better Semantic Maps compatibility had been rolled-back after a better 
solution had been found.

I have now restored the SMW 1.5.0 code:

http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/SemanticMediaWiki/includes/SMW_DataValue.php?r1=67279&r2=67519

> 
> <http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/SemanticMediaWi
> ki/includes/SMW_DataValue.php?r1=67090&r2=67279>I'd say it's an argument
>  for releasing a new version of SMW already, even so soon after the last
>  one...

I will probably just patch the old release when the LIKE issue is fixed.

-- Markus


> 
> -Yaron
> 
> On Sun, Jun 6, 2010 at 10:22 PM, Laurent Alquier <laur...@alquier.org>wrote:
> > One of my pages throws a long list of warnings like these :
> >
> > *Notice*: Uninitialized string offset: -1 in *
> > C:\Data\htdocs\smw\extensions\SemanticMediaWiki\includes\SMW_DataValue.ph
> >p * on line *684
> >
> > Starting at line 680:
> > *
> >     public function isNumeric() {
> >         $sig = $this->getSignature();
> >         $valueIndex = $this->getValueIndex();
> >
> >         return $sig { $valueIndex } == 'n' || $sig { $valueIndex } ==
> > 'f'; }
> >
> > For some reason, it looks like $valueIndex returns -1. Not sure why yet
> > but I will check that out,
> >
> > --
> > - Laurent Alquier
> > http://www.linfa.net
> >
> >
> > -------------------------------------------------------------------------
> >----- ThinkGeek and WIRED's GeekDad team up for the Ultimate
> > GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
> > lucky parental unit.  See the prize list and enter to win:
> > http://p.sf.net/sfu/thinkgeek-promo
> > _______________________________________________
> > Semediawiki-devel mailing list
> > Semediawiki-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/semediawiki-devel
> 


-- 
Markus Krötzsch  <mar...@semantic-mediawiki.org>
* Personal page: http://korrekt.org
* Semantic MediaWiki: http://semantic-mediawiki.org
* Semantic Web textbook: http://semantic-web-book.org
--

Attachment: signature.asc
Description: This is a digitally signed message part.

------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate 
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the 
lucky parental unit.  See the prize list and enter to win: 
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
Semediawiki-devel mailing list
Semediawiki-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/semediawiki-devel

Reply via email to