Hi Alex,

According to bug 32877 you have initially provided the JitGraph. We
went into some problems while testing 1.19beta and JitGraph therefore
we made same larger modifications to the JitGraph PHP implementation.
It would be nice if you would have a look at [1] it so that we don't
run off into different directions. The reworked JitGraph now is
similar to the re-factored D3[2] and jqPlot[3] SRF format which
abolish all inline HTML and JavaScript code and requires the
ResourceLoader.

## Changes

* All JS script elements and HTML has been outsourced to the
ext.srf.jit.forcedirected.js file
* Registration of all necessary modules are now via SRF_Resources.php
* Data objects are now transferred via mw.config.get/mw.config.set
instead of inline html <code>via "var json=" . $json   </code>

* Change the random id DIV generation and instead count the actual
existing objecs in a page and increase accordantly

* All JIT objects are encapsulated in an additional div object, width
and height can be assigned individually, more than one object can be
used in on page

* All resouce files have been moved to the sub-directory JitGraph/resources/

## Open issues

* Due to time the progressbar was not reimplemented

* We had no time to review the JSON tree but somehow this needs some
major rework as the current method does not create an appropriate
array structure.

* The JS uses some innerHTML statements ( as seen from the official
examples ) which is said to have some security issues, this might need
to be addressed and replaced by a more appropriate DOM manipulation.

[1] https://github.com/mwjames/smw-srfjitgraph

[2] https://github.com/mwjames/smw-srfd3

[3] https://github.com/mwjames/smw-srfjqplot

PS.:For now I leave the code in github, so issues can be addressed
before re-patching the existing implementation.

Cheers

mwjames

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
Semediawiki-devel mailing list
Semediawiki-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/semediawiki-devel

Reply via email to