Hi, > In the interest if not just patching our own code and making it available > to everyone, I'd like to push this change. But it is a change in behavior
We always welcome contributors, and for those who aren't familiar with the Semantic MediaWiki development and deployment process we recommend to skim the [0] document. > So what's the proper way to do this? Should I guard it behind a > flag that can be set in LocalSettings.php? Yes, for this purpose the `$smwgDVFeatures` setting [1] seems the most suitable. > flag that can be set in LocalSettings.php? Something else entirely? Not > worry about it and just make the change? For changes that alter existing behaviour and for any new functionality introduced we expect to see integration tests [2, 3] as per development policy [0] in order to establish that the newly introduced behaviour doesn't interfere with other functionalities and builds a base line for future enhancements. [0] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/docs/architecture/README.md [1] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/DefaultSettings.php#L1508 [2] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/tests/README.md [3] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/tests/phpunit/Integration/JSONScript/README.md Cheers On 4/19/19, Morgon Kanter <morgon.kan...@gmail.com> wrote: > It's document in getShortCaptionText() that it performs something similar > to the pipe trick. Unfortunately it's only half the pipe trick, it's > missing the part where values in parens get snipped. This is extremely > inconvenient, because my own wiki depends on having the full pipe trick > done. > > In the interest if not just patching our own code and making it available > to everyone, I'd like to push this change. But it is a change in behavior > and output. So what's the proper way to do this? Should I guard it behind a > flag that can be set in LocalSettings.php? Something else entirely? Not > worry about it and just make the change? > > Thanks, > -- Morgon > _______________________________________________ Semediawiki-devel mailing list Semediawiki-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/semediawiki-devel
