Hi Andreas,
o Andreas Granig [07/14/09 19:03]:
So what I did was splitting up public_ip config option into
advertised_media_ip and advertised_sip_ip.
looks good!
In sipctrl I changed Via and Contact creation to take into account the
advertised_sip_ip parameter.
I also changed the previous public_ip handling throughout sems
(replacing advertisedIP() by advertisedMediaIP()), and call-id creation
(use advertised_sip_ip by calling advertisedSIPIP() if set).
however, do you expect AmConfig::AdvertisedMediaIP to change while SEMS
is running of why do you check for its presence every time
AmConfig::advertisedMediaIP() is called? if it does not change, after
configuration read, this check could be done once and then it is set.
I although noted in conference module that public_ip was not handled
there (AmConfig::LocalIP was used instead of AmSession::advertisedIP()),
but I let it as is because I don't know the implications of changing
that one.
This is a left-over (bug), it should actually be the same as e.g. in
AmSession::negotiate.
Thanks
Stefan
--
Stefan Sayer
VoIP Services
[email protected]
www.iptego.com
IPTEGO GmbH
Wittenbergplatz 1
10789 Berlin
Germany
Amtsgericht Charlottenburg, HRB 101010
Geschaeftsfuehrer: Alexander Hoffmann
_______________________________________________
Sems mailing list
[email protected]
http://lists.iptel.org/mailman/listinfo/sems
