Hello All! 2008/8/13 Raphael Coeffic <[EMAIL PROTECTED]>: > Peter Lemenkov wrote:
[skip] >> Another one note is a mess with the source layout - what's the >> difference between apps and code/plug-in content? Seems that it would >> be better to merge them. On the other hand, content of apps/examples >> directory should be moved to its own director, probably at top level >> (sems-1.0.0/examples). Before such move, content of >> apps/examples/tutorial should be moved one directory up and merget >> therefore with examples content. It's just my opinion, though. > code/plug-in is supposed to contain general purpose plug-in that will always > be loaded, or should be part of the base version. The apps directory > contains all the plug-in which can be used separatly for specific purposes. > Does it make sense? OK, understood. >> There is also a discrepancy in placing of Readme.* files - some of >> them placed in docs, while others - in the directories of their >> respective modules I personally think that the latter variant is >> better (all information about particular module placed in one place). >> That's also just my personal opinion. >> >> And one simple note - you shipped init-script for RedHat, which quite >> outdated. According to latest RedHat/Fedora policy only services for a >> vital system should have a default runlevel list in their initscript. >> Easy to fix, actually (see patch): >> >> http://peter.fedorapeople.org/sems--initscript_fix.diff > > Many thanks for your work and comments! Another note - compilation of module unixsockctrl should produce two libraries - one for OpenSER and another for SER. I haven't decided yet what to to with this, but I need to ship both libraries, because some users using SER while others (including me) using OpenSER/Kamailio/OpenSIPS with SEMS. -- With best regards! _______________________________________________ Semsdev mailing list [email protected] http://lists.iptel.org/mailman/listinfo/semsdev
