Hi Robert,
Robert Szokovacs wrote:
On 2010 June 19, Saturday 16:28:04 you wrote:
Hi Robert,
Robert Szokovacs wrote:
Hi,
In RFC3261, sections 7.3.x it is mentioned that it is legal to have
multiple SIP header with the same header name and also legal to combine
those to comma separated values in a single header.
The current SEMS doesn't seem to support this:
- getHeader() in AmSipMsg.cpp only returns the first one if there are
multiple headers.
- get_header_keyvalue() in AmUtils.cpp is not aware of the possibility of
multiple values separated by comma.
that's right, there is some issues with these functions.
I have added this to the bug on the tracker:
https://bugtracker.iptel.org/view.php?id=24
Hi,
I have attached a patch that addresses the issues I described. I introduced a
thanks a lot for the patch. I have applied it (slightly modified) to
HEAD. btw, you can add some test cases to tests/test_headers if you like.
boolean parameter to getHeader() which switches between the old and the
"correct" behaviour (defaulted to the correct) and patched all places to use
the old one so I hope nothing broke. Also had to add a new parameter to
I am wondering: in most cases, the new ("correct") behaviour would be
better, right?
findHeader. Modified removeHeader() also to remove all instances of the header
specified.
Regarding the original problem in 0000024, I had trouble finding out the exact
format of the parameter from the RFC. Is it legal to the key be quoted? Can it
contain escaped characters? Which ones? Same with the value. Is it legal to
have whitespace around the "=" ? Etc. Any pointers?
there is actually no RFC for that - the P-App-Param header is SEMS'
creation. So we are free to put the syntax the way it fits best. In
fact I think that
- it would make sense to support quoted strings (with " as \")
- it would make sense to support whitespace around "="
As this P-App-Param is mostly used inside a platform (which you fully
control, e.g. the sr script), usually it works because you the one who
is setting up SEMS is also setting up the proxy.
Stefan
br
Szo
------------------------------------------------------------------------
_______________________________________________
Semsdev mailing list
[email protected]
http://lists.iptel.org/mailman/listinfo/semsdev
--
Stefan Sayer
VoIP Services Consulting and Development
Warschauer Str. 24
10243 Berlin
tel:+491621366449
sip:[email protected]
email/xmpp:[email protected]
_______________________________________________
Semsdev mailing list
[email protected]
http://lists.iptel.org/mailman/listinfo/semsdev
