Module: sems
Branch: master
Commit: 1aac352a5a851e05ea2601cfbfc30ab3814b4a82
URL:    
http://git.sip-router.org/cgi-bin/gitweb.cgi/sems/?a=commit;h=1aac352a5a851e05ea2601cfbfc30ab3814b4a82

Author: Raphael Coeffic <[email protected]>
Committer: Raphael Coeffic <[email protected]>
Date:   Tue Dec 13 11:24:47 2011 +0100

b/f: reactivate 'a=direction:...' support CORRECTLY.

Passive mode should only be set after correct offer/answer, and not while 
generating the answer.

---

 core/AmRtpStream.cpp |    3 +--
 core/AmSession.cpp   |    2 --
 2 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/core/AmRtpStream.cpp b/core/AmRtpStream.cpp
index a29fb5c..9d460dd 100644
--- a/core/AmRtpStream.cpp
+++ b/core/AmRtpStream.cpp
@@ -623,10 +623,9 @@ int AmRtpStream::init(AmPayloadProviderInterface* 
payload_provider,
   }
 
   //TODO: support mute, on_hold & sendrecv/sendonly/recvonly/inactive
-  //      support for passive-mode
 
   setLocalIP(local.conn.address);
-  //setPassiveMode(remote_active);
+  setPassiveMode(remote_media.dir == SdpMedia::DirActive);
   setRAddr(remote.conn.address, remote_media.port);
 
   // TODO: take the first *supported* payload
diff --git a/core/AmSession.cpp b/core/AmSession.cpp
index 371d114..9802443 100644
--- a/core/AmSession.cpp
+++ b/core/AmSession.cpp
@@ -1020,8 +1020,6 @@ bool AmSession::getSdpAnswer(const AmSdp& offer, AmSdp& 
answer)
     break;
   }
 
-  RTPStream()->setPassiveMode(answer_media.dir == SdpMedia::DirPassive);
-
   // Calculate the intersection with the offered set of payloads
 
   vector<SdpPayload>::const_iterator it = m_it->payloads.begin();

_______________________________________________
Semsdev mailing list
[email protected]
http://lists.iptel.org/mailman/listinfo/semsdev

Reply via email to