On 2012 Mar 30, Fri 14:43:32 Stefan Sayer wrote: > o Robert Szokovacs on 03/27/2012 10:51 AM: > > On 2012 Mar 26, Mon 19:25:40 Juha Heinanen wrote: > >> Ivr.cpp/ivr_getHeader function calls getHeader function like this: > >> string res = getHeader(headers,header_name, true); > >> > >> 'true' is value of 'single' argument telling if only single header or > >> all headers with 'header_name' should be considered. > >> > >> is there some good reason why 'single' param value is not 'false'? > >> > >> for example, if there is many P-App-Param headers in incoming message, > >> all of them would become available with 'false' value of 'single' > >> param. > > > > I think it was set to true, because when we updated the getHeader function > > to have the capability to return all the headers, we did not want to > > break the existing IVR apps that assume they get a single header handed > > to them. > are you ok with just changing that to false and return all headers? > > I feel it's better to return all values, instead of omitting some > values there.
I think in case of IVR, we should go with Juha's suggestion and introduce another function. (Or maybe expose the "single" parameter in IVR's getHeader too, with "false" default value) br Szo _______________________________________________ Semsdev mailing list [email protected] http://lists.iptel.org/mailman/listinfo/semsdev
