Hi Robert,
thanks for reporting these problems.
With the "%lu" warning it could be difficult. Can't different STL
implementations (or compiling on different architectures) cause that different
type is used?
After changing to %u:
WARN("trying to relay SDP with more media lines than "
"relay streams initialized (%u)\n", audio.size());
I got the warning:
core/AmB2BMedia.cpp|555 col 5| warning: format ‘%u’ expects argument of
type ‘unsigned int’, but argument 4 has type
‘std::vector<AmB2BMedia::AudioStreamPair>::size_type {aka long unsigned int}’
[-Wformat]
(x86_64 architecture, gcc 4.7.1)
Looking into the code I would say that currently there is no problem in having
non-virtual destructors for AmDtmfSink and RelayController. Anyway if anybody
would like to use them different way it could harm.
Vaclav
On Pá, srp 03, 2012 at 11:50:04 +0100, Szokovacs Robert wrote:
> Hi,
>
> I just upgraded to SEMS 1.5.0 and noticed some warnings:
> Building with gcc version 4.6.3:
> AmB2BMedia.cpp:555:5: warning: format ‘%lu’ expects argument of type
> ‘long unsigned int’, but argument 4 has type
> ‘std::vector<AmB2BMedia::AudioStreamPair>::size_type {aka unsigned
> int}’ [-Wformat]
> more of the same in AmEventDispatcher.cpp. These don't cause
> problems, but I see no reason not to fix them.
> Building with gcc version 4.1.2 20061115:
> AmDtmfDetector.h:388: warning: ‘class AmDtmfSink’ has virtual
> functions but non-virtual destructor
> AmB2BMedia.h:36: warning: ‘class RelayController’ has virtual
> functions but non-virtual destructor
> I think these can lead to interesting problem if remains unfixed.
>
> br
>
> Szo
> _______________________________________________
> Semsdev mailing list
> [email protected]
> http://lists.iptel.org/mailman/listinfo/semsdev
_______________________________________________
Semsdev mailing list
[email protected]
http://lists.iptel.org/mailman/listinfo/semsdev
