On Apr 30, 12:42 am, Mike Golod <[email protected]> wrote: > On 30 апр, 03:31, Jeremy Evans <[email protected]> wrote: > > > I'm not sure why, but that diff didn't apply (probably the Google > > Group messing it up). Could you try the one athttp://pastie.org/463240.txt > > and let me know if it works? > > Yes, applies cleanly. Results of "rake integration" are > herehttp://pastie.org/463584.txt(specs unmodified)
Thanks for your help, I just committed the change, and it will be in 3.0. From the integration test results, I see we need a few things: 1) Catch OCIErrors and raise them as Sequel::DatabaseErrors 2) Make the pool not convert exceptions in the Oracle adapter 3) Handle inserts with no values (Oracle doesn't support DEFAULT VALUES apparently) 4) Change some mappings of generic types to database specific types 5) Review string quoting and make sure it is correct There's probably some other things as well. Anyway, I'm happy to accept patches that increase support of Oracle, so if you want to work on any of these issues, please do so and send in patches. Thanks, Jeremy --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sequel-talk" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/sequel-talk?hl=en -~----------~----~----~----~------~----~------~--~---
