I don't mind moving it over to the MySQL adapter and it makes sense to do it. It would be nice to set the default to false but I'd leave that up to you so you can document the change properly.
On Jul 9, 4:04 pm, Jeremy Evans <[email protected]> wrote: > On Jul 9, 11:31 am, Jason Carr <[email protected]> wrote: > > > That works just fine, thank you. > > > Having a tinyint(1) be a TrueClass and a tinyint(4) be a Fixnum might > > be useful. I'm assuming this code is not available already? > > It might be, but doing so would break backwards compatibility. > However, the whole situation should probably be given some additional > thought. For one, the only adapter that respects the setting is the > native MySQL adapter. Other adapters don't convert tinyint values to > booleans (most adapters don't type convert values retrieved by the > underlying driver). convert_tinyint_to_bool should probably be made a > native MySQL driver specific setting. > > > There's always the chance that I'm using tinyint(4)'s incorrectly.. :) > > Doubtful. Personally, I don't like the idea of converting tinyint's > to bools, but MySQL has no native boolean type. To be fair, this is a > problem with older SQL in general, as SQL-92 didn't define a boolean > type (it was added in SQL:1999). > > If this is something you want to work on, let me know. Otherwise, > I'll add it to my todo list. > > Jeremy --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sequel-talk" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/sequel-talk?hl=en -~----------~----~----~----~------~----~------~--~---
