On Sep 8, 2:38 pm, Joel VanderWerf <[email protected]> wrote: > Jeremy Evans wrote: > >http://github.com/jeremyevans/sequel/commit/53a1428c4e3e37369cb811640... > > Looks good. The only thing I would add is an inspect method: > > module Sequel > class Error < ::StandardError > def inspect > "#<#{self.class}: #{wrapped_exception.inspect}> > end > end > end
I don't think this is a good idea. For Errors with wrapped_exceptions, the current code already gives you: #<Sequel::InvalidValue: ArgumentError: invalid date> Which I think is superior to: #<Sequel::InvalidValue: #<ArgumentError: invalid date>> And certainly the current code for Errors without wrapped exceptions: #<Sequel::InvalidOperation: EXCEPT ALL not supported> Is better than your suggestion: #<Sequel::InvalidOperation: nil> Jeremy --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sequel-talk" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/sequel-talk?hl=en -~----------~----~----~----~------~----~------~--~---
