On Sep 25, 3:35 am, David Lee <[email protected]> wrote: > Hi, > > Sequel::Model's #limit/offset don't work using jdbc mssql because the > row_proc to instantiate Model objects is being called before mssql's > #each override gets to remove the row_number value. > > I would not suggest taking the quick fix approach to check if the > yielded object (in mssql's #each's block to super) is a Hash or Model, > since doing that would hurt performance and also still allow the > row_number value to be passed to Model.load, which might be overridden > to do further processing on the values unexpecting the row_number > value. > > There were various ways I was thinking we could fix this, but I was > thinking you might have an elegant refactoring in the back of your > mind that you would use.
Hmm, maybe we should be overriding fetch_rows instead. Try the diff at http://pastie.org/630623.txt. Jeremy --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sequel-talk" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/sequel-talk?hl=en -~----------~----~----~----~------~----~------~--~---
