Overall that sounds good - just checked the commits, thanks for the fast patches.
Regarding the bind_filter approach, though, I'm still not too hot on it to be honest. I guess I don't see a case where I'd not want bind vars when dealing with Oracle. And I also don't see how it would handle inserts/updates that are deep within the Sequel::Model API User.create(props) user = User[id] user.name = 'Yo' user.update etc etc I like the Sequel DSL and I'm sure the programmers on my team will want to do User.filter(stuff).group_by(stuff).order(stuff).etc.etc I don't want to have to wrap basically the entire Sequel DSL User.bind_filter(stuff).bind_group_by(stuff).bind_order (stuff).etc.etc How about my other suggestion of just a global flag? Sequel.connect(..., :use_bind_variables => true) ? -Nate --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sequel-talk" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/sequel-talk?hl=en -~----------~----~----~----~------~----~------~--~---
