On Oct 17, 8:30 pm, Jeremy Evans <[email protected]> wrote: > I'll look at your branch in a little while and see if I can figure out > what is going wrong.
Try http://pastie.org/659227.txt It should apply to your branch and fix the issues. The spec failures were caused because things that needed to be mocked weren't. I also modified your remove implementation to check that the object you are attempting to remove via the primary key is actually associated to the object. Otherwise, you could remove the association for a object associated to a different object. It's assumed that if you are passing an object, you know the object is already associated, but I don't think that's a safe assumption for a primary key value. I'm not even sure it is a safe assumption for the object case. Anyone else have opinions either way? I've committed the patch linked above in one of my private branches. It should be on github after I run it through the full test suite on Monday. Thanks for the patch! Jeremy --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sequel-talk" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/sequel-talk?hl=en -~----------~----~----~----~------~----~------~--~---
