On Feb 8, 10:12 pm, Clive Crous <[email protected]> wrote:
> On 8 February 2010 20:56, Jeremy Evans <[email protected]> wrote:
>
> > Try the diff athttp://pastie.org/815005.txt, and make sure to provide
> > a :key option to foreign_key, since MySQL/InnoDB requires it.
>
> Hi Jeremy,
>
> I've not yet tried the patch since adding :key => :id fixed
> everything. Perhaps the patch (if any) should rather insist on getting
> a :key option when InnoDB is used?

The problem with that is that there is no way to tell if InnoDB is
used by default.  I suppose I could check only the cases where we are
setting the engine to InnoDB explicitly, but the only difference there
is the subclass of Sequel::Error that will be raised.  Is it really
worth it?

I still think the patch is a good idea, and it's already been pushed.

Jeremy

-- 
You received this message because you are subscribed to the Google Groups 
"sequel-talk" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sequel-talk?hl=en.

Reply via email to