Ok, so I'll stop my own patching efforts. I had made the changes and had what appeared to be working, but got stuck on figuring out how to run the specs and was planning to continue this weekend. But yeah, I ran up against that limit(1) issue with a number of things like Dataset#columns, and so on.
If you want to give me some pointers on running specs, I'll be happy to make a habit of running specs against MSDE 2000 when it comes time for regression testing before release. Michael On Fri, Mar 19, 2010 at 12:52 PM, Jeremy Evans <[email protected]>wrote: > On Mar 12, 12:41 am, Gary Doades <[email protected]> wrote: > > On 12/03/2010 3:57 AM, Jeremy Evans wrote:> This was a recent change in > Sequel (between 3.8.0 and 3.9.0). It was > > > done to allow you to make the limit a bound variable in a prepared > > > statement, which doesn't work without the parentheses in 2008 (and I > > > think 2005 as well). I'll accept a patch to the shared MSSQL adapter > > > that omits the parentheses if we detect that we are working on a > > > pre-2005 MSSQL. In the mean time, it should be fairly easy to monkey > > > patch, seehttp:// > github.com/jeremyevans/sequel/blob/master/lib/sequel/adapters/.... > > > > OK, thanks for that. I think I'll just go with monkey patching for now. > > We are moving to 2008 so I don't think it's worth putting in the main > > line code just for a few months. > > > > > Also, you should know that I don't test on MSSQL 2000 (only on 2008). > > > At the very least, limit with an offset is also broken on MSSQL 2000, > > > and that isn't possible to fix correctly in all cases > > > > He he.. I don't *want* to work with MSSQL 2000, just no choice for a > > little while longer :( > > > > Limit/offset is just another reason why it's probably not worth trying > > to come up a with patches that try to suit all versions. > > Because limit(1) is used extensively internally in Sequel, I decided > to fix this for MSSQL 2000: > http://github.com/jeremyevans/sequel/commit/dd1b39fd37e4ade5071f330be5fce77ebedeb833 > > Offset is only used when you request it, and that can't be fixed > perfectly on MSSQL 2000, so I don't plan to work on that. > > Jeremy > > -- > You received this message because you are subscribed to the Google Groups > "sequel-talk" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<sequel-talk%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/sequel-talk?hl=en. > > -- http://codeconnoisseur.org -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sequel-talk?hl=en.
