Seems to me the better approach is to keep the default "client" and pass in
an option that can potentially override it and thus maintain backwards as
well as widest compatibility.  I personally rarely change the mysql config
files unless its to move the socket file elsewhere and even then, that's a
rarity these days and I have definitely never added a "sequel" group to any
of mine.

How about simply changing line #97:

 conn.options(Mysql::READ_DEFAULT_GROUP, opts[:config] || "client")

Then, if somebody needs to use a different group, they can override with
:config => "sequel" or whatever suits their needs.

Michael


On Thu, Apr 1, 2010 at 12:25 PM, Jeremy Evans <[email protected]>wrote:

> gaiottino has sent me a pull request for a small change to the native
> MySQL adapter.  I don't use MySQL except for testing Sequel, so I'm
> not able to judge whether it's a good idea to merge this patch.  If
> you use MySQL, could you give a recommendation either way?  Here's the
> commit:
>
>
> http://github.com/gaiottino/sequel/commit/a46407bba3a618dc71c0e1bf25c79193cef9343c
>
> Thanks,
> Jeremy
>
> --
> You received this message because you are subscribed to the Google Groups
> "sequel-talk" group.
> To post to this group, send email to [email protected].
> To unsubscribe from this group, send email to
> [email protected]<sequel-talk%[email protected]>
> .
> For more options, visit this group at
> http://groups.google.com/group/sequel-talk?hl=en.
>
>


-- 
http://codeconnoisseur.org

-- 
You received this message because you are subscribed to the Google Groups 
"sequel-talk" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sequel-talk?hl=en.

Reply via email to