On Jun 7, 12:41 pm, Nate Wiger <nwi...@gmail.com> wrote: > Cool - looks great - thanks. Seeing your changes helps me understand > the plugin structure a bit better. > > One thing. Once you go to Ruby 1.9.2, you'll need this > File.expand_path, which you removed: > > require File.expand_path File.join(File.dirname(__FILE__), > "spec_helper") > > Otherwise, "spec spec/blah_spec.rb" stops working. This is because > Ruby 1.9.2 removed "." from RUBYLIB (stupidly, IMO, but > nonetheless...)
True, but such a change should be made to all specs at the same time. I don't currently test on 1.9.2, but I will after it is officially released. If you want to submit a patch now to modify all of the specs to use expand_path instead of join, that's fine if it is really necessary on 1.9.2. It should only be necessary if __FILE__ is not already an absolute path, though. Is __FILE__ not an absolute path on 1.9.2? And I completely agree with you about the RUBYLIB change. Jeremy -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To post to this group, send email to sequel-t...@googlegroups.com. To unsubscribe from this group, send email to sequel-talk+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sequel-talk?hl=en.
