On Nov 30, 11:04 am, george <[email protected]> wrote: > i worked around the issue last night using a mixin/extention very > similar to what you described. i also came across that very same json > parser code after i sent my email to this group... perhaps we could > convince flori to do a refactor that will push the options hash from > the JSON.parse() call all the way down through the .json_create() > calls!?!
We could try, but it would be hard to do so without breaking backwards compatibility. You'd have to at least check the arity of the json_create method, so you don't send multiple arguments to a method accepting only a single argument. Even then, you'd still break code where the json_create method accepts two arguments and has a default second argument that was not expected to be the options hash. Such code is rather unlikely, I think, so maybe flori will be open to it. > > With the patch I'll be committing, that hopefully will take care of > > your needs. > > thank you very much, sir, im looking forward to it! Committed earlier today, will be in 3.18.0: https://github.com/jeremyevans/sequel/commit/37bdf0409b260ee6ba3e8ff9a0ce33acc171b751 Jeremy -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sequel-talk?hl=en.
