On Aug 29, 8:23 pm, Jeremy Evans <[email protected]> wrote: > On Aug 22, 2:02 pm, Jeremy Evans <[email protected]> wrote: > > > Seehttp://pastie.org/2413439forthe patch. I'm not sure if I want > > to commit this to Sequel because of the potential backwards > > compatibility issues. I'd like to get opinions from the community > > before I make my decision. > > This commit doesn't handle the following case correctly: > > DB.literal(:x + 1 + > 'a') > => "((x + 1) || 'a')" > > It should be raising an error. It's not difficult to fix that, but > due to the potential backwards compatibility issues and the fact that > nobody chimed in that they'd like this feature, I'll probably shelve > the idea.
After some more thought, I'm planning to merge a modified version of this patch that fixes the errors mentioned and other errors due to mixing SQL types that shouldn't be mixed (addition on strings, string concatenation with numerics, etc.). It won't get pushed till Monday, so if you have some strong objection to it, please post before then with your reasons. Jeremy -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sequel-talk?hl=en.
