On Tuesday, September 25, 2012 2:43:45 AM UTC-7, Christoffer Sawicki wrote:
>
> Hi Jeremy!
>
> Thanks for the note.
>
> My application does currently not handle requests concurrently, but I took
> the time to fix the middleware for the future and others:
>
> http://pastie.org/private/zdrp9zhi7vrhidgo3vagg
>
> Note that it never tries to reprocess a request when it has started; it
> only tries to reconnect before beginning request processing.
>
> Can you see any more potential pitfalls?
>
This looks good. I would only recommend two changes.
1) Use @db.run(@db.select(1).sql) instead of @db.run("SELECT 1"). Some
databases require a dummy FROM clause, and "SELECT 1" is invalid SQL on
those databases.
2) Log to all of Sequel's loggers, as opposed to just the first logger.
Thanks,
Jeremy
--
You received this message because you are subscribed to the Google Groups
"sequel-talk" group.
To view this discussion on the web visit
https://groups.google.com/d/msg/sequel-talk/-/oBpvG0md5BcJ.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sequel-talk?hl=en.
