While browsing the source code of sequel, I noticed that there is quite a bit of trailing whitespace in the code base. Since I'm usually navigating block-wise through code, I found this a bit annoying and set out to remove all its occurences from the project and opened a pull request (https://github.com/jeremyevans/sequel/pull/706).
This PR however was denied for two reasons: 1) it made the test suite fail (see https://github.com/jeremyevans/sequel/pull/706#issuecomment-24745478 for details) 2) if trailing whitespace is removed from the code base, then this should become a policy/style guideline, checks need to be in place to prevent reintroduction, etc.. this policy decision however should be made by the contributor community and not me (https://github.com/jeremyevans/sequel/pull/706#issuecomment-24740970) I obviously would like to see no more trailing whitespace in the project, but what are your opinions? -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sequel-talk. For more options, visit https://groups.google.com/groups/opt_out.
