On Monday, February 17, 2014 6:41:01 PM UTC-8, Jeremy Evans wrote: > > On Monday, February 17, 2014 5:39:00 PM UTC-8, Ross Attrill wrote: >> >> I have found that the MSSQL sub-adapter of the ODBC adapter does not >> insert milliseconds from variables that are date-time timestamps. >> >> MSSQL will accept 3 millisecond decimal places, but the ODBC adapter >> won't pass these. >> >> I was able to patch the code fairly easily to fix this as shown here: >> >> >> https://github.com/rjattrill/sequel/commit/766e595f7b5fc9876c7c704c693b568e4ed7aa9e >> >> However, I could not work out how to add a test case as I am not that >> familiar with Ruby nor Rake in particular. There are existing tests here: >> https://github.com/jeremyevans/sequel/blob/master/spec/adapters/mssql_spec.rb#L24, >> >> but I couldn't work out how to get Rake to execute them. (Starting with >> 'rake default'.) The existing test case at that location seems to >> indicate that millisecond precision is expected from the adapter, but that >> is not what I see in execution. >> >> Jeremy, will you accept a pull request without a spec to prove that there >> is a problem and that the patch fixes this? If not would it be possible >> to ask for some guidance on how to invoke the tests in mssql_spec.rb? >> >> Thank you, >> >> Ross Attrill >> > > Ross, > > That patch looks fine, I'll try merging and testing it tomorrow (including > removing the relevant guards from the specs). You can run the mssql specs > with rake spec_mssql (for details, see > http://sequel.jeremyevans.net/rdoc/files/doc/testing_rdoc.html). >
I've merged the patch with some additional fixes, as well as removing some related guards in the specs. Thanks, Jeremy -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sequel-talk. For more options, visit https://groups.google.com/groups/opt_out.
