On Thursday, September 4, 2014 12:16:49 PM UTC-7, Ahto Jussila wrote:
>
> Hi,
>
> I hear about this new database http://crate.io and wanted to learn how it 
> works, thought that making it work with Sequel would be good practice 
> learning what it can do.
>
> There is some work done here:
>
> Adapter: 
> https://github.com/ahto/sequel-jdbc-crate/blob/master/lib/sequel/adapters/jdbc/crate.rb
> Trying what features work: 
> https://github.com/ahto/sequel-jdbc-crate/blob/master/examples.rb
>
> My method was pretty brute force. Make some example and make it work by 
> any means necessary.
>
> What do you think about the current state of the adapter code?
>
> On the roadmap next is: specs and support some of the special features 
> like binary blob tables.
>
> The current state is experimental, it will get some real world usage in 
> the coming weeks.
>

 If you real want to test how it works with Sequel, try running the Sequel 
integration tests using the jdbc/crate adapter, and then work on fixing the 
failures.

Some notes:

1) If crate doesn't support transactions, many of the integration tests 
will fail.

2) There's no point in defining schema_parse_table but not actually parsing 
the schema.  Then you just have silent breakage.

3) to_application_timestamp is wrong.  The application timestamp may be 
:utc and not :local, so enforcing local time is wrong.  Maybe you just want 
to change the argument and call super?

4) complex_expression_sql_append should be changed to not add the ESCAPE 
clause, instead of attempting to gsub the SQL after adding it.  See the 
Access shared adapter for an example.

Thanks,
Jeremy

-- 
You received this message because you are subscribed to the Google Groups 
"sequel-talk" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sequel-talk.
For more options, visit https://groups.google.com/d/optout.

Reply via email to