Hi Jeremy, On Sat, Feb 14, 2015 at 11:04:46PM -0800, Jeremy Evans wrote: > Just some minor recommendations:
Thanks for those, I really appreciate you taking the time to look over the code. They're all mistakes caused by my lack of familiarity with Sequel's features, and I'll chip away at all of them over the next little while. > 3) Have a different method or add second argument to comment_for to > indicate column comments. With the current API, you can't differentiate a > request for a schema qualified table from a request for a column in a > table. I was wondering about schema-qualified tables. I noticed a few places where schemas were mentioned, but couldn't find anything definitive on when :foo__bar meant "column foo on table bar" or "table bar in schema foo". > 4) Dataset#comment_for without an argument should probably give you the > comment for the table. One easy hack for this is to have the default > argument value be: return db.comment_for(first_source_table) Ooooh, that's a *neat* idea. > 6) Instead of overriding generator methods to recognize the :comment > option, override the Database schema methods (e.g. > Database#create_table_indexes_from_generator, which you are already > overriding) to check for the :comment option. That would probably simplify > things quite a bit. I'm not sure what you mean here, but I'll cogitate on it a little and I'm sure it'll come to me. Thanks, - Matt -- The New York Times: the paper that asks for more verification from its readers than its writers. -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sequel-talk. For more options, visit https://groups.google.com/d/optout.
