Sorry for the impolite phrasing, I assumed there was something that I was missing. PR sent :)
On Sunday, July 26, 2015 at 5:53:29 PM UTC+2, Jeremy Evans wrote: > > On Sunday, July 26, 2015 at 6:25:30 AM UTC-7, Janko Marohnić wrote: >> >> Hi Jeremy, >> >> A while ago you added the =~ and !~ operators >> <https://github.com/jeremyevans/sequel/commit/2081f746812757039f79c6132a718b9cb682f048> >> to >> GenericExpressions. I was just wondering, why didn't you also add it to >> Expressions or ComplexExpressions (or some further subclass)? For example, >> I noticed that the following code won't work: >> >> DB[:movies].where{date.extract(:year) =~ 2015} >> >> I was thinking that it would make sense to have it always default to "=" >> in SQL. >> > > I wasn't actively excluding it, I just didn't think about it. I think > including PatternMatchMethods in ComplexExpression should be fine. Can you > send a pull request for that with a test? > > Thanks, > Jeremy > -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sequel-talk. For more options, visit https://groups.google.com/d/optout.
