Hello -

I'm using the null_dataset extension, which mentions a performance issue 
due to the use of Object#extend. It seems to me that we could get the same 
behavior simply by having nullify clone the ds with a "nullified" (or 
similar) dataset option, and the methods being overridden in that model 
would simply check for the presence of that key and call super if it 
doesn't exist. I expect this would be faster, though I haven't benchmarked 
it, and it seems more in keeping with the design of the rest of Sequel.

Does this seem like a reasonable goal? I'd be happy to work up a PR for it 
if it sounds acceptable.


You received this message because you are subscribed to the Google Groups 
"sequel-talk" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sequel-talk+unsubscr...@googlegroups.com.
To post to this group, send email to sequel-talk@googlegroups.com.
Visit this group at https://groups.google.com/group/sequel-talk.
For more options, visit https://groups.google.com/d/optout.

Reply via email to