On Tuesday, July 4, 2017 at 9:08:22 AM UTC-7, Jeremy Evans wrote:
>
> On Tuesday, July 4, 2017 at 8:02:05 AM UTC-7, Aryk Grosz wrote:
>>
>> Hey Jeremy, not sure if this was intended or not:
>>
>> opts[:decomposer] = proc do
>>   if (o = compositions[name]).nil?
>>     setter_meths.each{|sm| get_column_value(sm, nil)}
>>   else
>>     setters.each{|sm, cm| get_column_value(sm, o.send(cm))}
>>   end
>>
>>
>>
>> I think you would want "set_column_value" here, right? They both call 
>> "send" by default which is why it works now, but if somebody overwrote 
>> those methods, this would be a problem.
>>
>
> Yep, that looks like a bug, Can you send a PR to fix it?
>

I just committed a fix: 
https://github.com/jeremyevans/sequel/commit/1fbfd9cc95c3433ea214bba16a8a4284e88c8a7b

Thanks,
Jeremy 

-- 
You received this message because you are subscribed to the Google Groups 
"sequel-talk" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sequel-talk.
For more options, visit https://groups.google.com/d/optout.

Reply via email to