This is great news, and super helpful to see how you implemented it. Thank you! (I spent some time working on it, and got stymied by not knowing enough about where adapter-specific code should live.)
On Wed, Oct 10, 2018 at 11:23 AM Jeremy Evans <[email protected]> wrote: > On Tuesday, September 4, 2018 at 8:07:08 AM UTC-7, Jeremy Evans wrote: >> >> On Tuesday, September 4, 2018 at 7:25:49 AM UTC-7, Chris Frank wrote: >>> >>> Thanks for clarifying, Jeremy. I like your idea of emulating this >>> behavior, and I think I'd enjoy working on it. I'm not sure I understand >>> what you have in mind by "an additional order term", but if you write a >>> line or two demonstrating how you'd want the API to look, I'll get to work >>> on it this week. >>> >> >> This wouldn't require any API changes. If the database doesn't support >> NULLS FIRST/LAST, you can probably emulate it via: >> >> # ORDER BY a NULLS FIRST >> ORDER BY CASE WHEN a IS NULL THEN 1 ELSE 2 END, a >> >> # ORDER BY a NULLS LAST >> ORDER BY CASE WHEN a IS NULL THEN 2 ELSE 1 END, a >> >> Dataset#ordered_expression_sql_append is the method you would want to >> modify. >> > > I've committed support for this: > https://github.com/jeremyevans/sequel/commit/51d96b8700df2c4cae9963bd90428efc92755e43 > > Thanks, > Jeremy > > -- > You received this message because you are subscribed to the Google Groups > "sequel-talk" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at https://groups.google.com/group/sequel-talk. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/sequel-talk. For more options, visit https://groups.google.com/d/optout.
