Thanks Jeremy! The PR can be found at https://github.com/jeremyevans/sequel/pull/1580
On Friday, December 7, 2018 at 6:55:17 AM UTC-8, Jeremy Evans wrote: > > On Friday, December 7, 2018 at 12:20:03 AM UTC-8, Kenaniah Cerny wrote: >> >> Hi all, >> >> I have a code base that is currently using both the schema_caching >> extension and the class_table_inheritance model plugins. I noticed that the >> CTI plugin does not utilize the schema cache even when it is available, and >> prefers to query the datasource instead. >> >> >> https://github.com/jeremyevans/sequel/compare/master...spidrtech:cti-schema-cache >> >> is my attempt at a starting point for how those additional queries could >> potentially be eliminated altogether, but I wanted to see if there was a >> preferred approach before getting too far into the weeds on this. >> > > So far, the approach looks good. It probably needs more work, but after > it is finished, please submit it as a pull request. You'll probably want > to add specs to check that it isn't issuing queries to get the columns, and > is instead calling the schema method. > > Thanks, > Jeremy > -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to sequel-talk+unsubscr...@googlegroups.com. To post to this group, send email to sequel-talk@googlegroups.com. Visit this group at https://groups.google.com/group/sequel-talk. For more options, visit https://groups.google.com/d/optout.
