That makes sense. Really appreciate your help! I am testing the disable_quoting feature. I think the sqlite database was created with case-insensitivity in mind so I don't think there should be any issues (does not seem like overlapping or spaces are a thing in this db). I think currently the idea is to migrate the sqlite database to a psql database so shouldn't be an issue to disable quoting?
On Thu, Aug 20, 2020 at 2:46 PM Jeremy Evans <[email protected]> wrote: > On Thursday, August 20, 2020 at 12:34:07 PM UTC-7, Anant M wrote: >> >> Hi, >> >> Thanks for the help! I will fix the source database which is of course >> the better solution, but I did want to ask as pgloader does not seem to use >> identifier quoting, so I was curious as to the practice of using it and >> whether it was better to use double quotes over no quotes. >> > > I think the general database design advice would be: don't use any > identifiers where quoting would affect the query. Unfortunately, disabling > quoting by default would not work well for Sequel because then using > identifiers that require quoting (e.g. because they overlap with keywords > or contain spaces) would break things. Additionally, not quoting results > in behavior that differs across databases, since foo (unquoted) is the same > as "FOO" on some databases and the same as "foo" on other databases. Sequel > takes the conservative approach of quoting all identifiers. > > Thanks, > Jeremy > > -- > You received this message because you are subscribed to a topic in the > Google Groups "sequel-talk" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/sequel-talk/NgD2igk8ks0/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sequel-talk/24d960d1-d371-4308-923d-73139eef4951o%40googlegroups.com > <https://groups.google.com/d/msgid/sequel-talk/24d960d1-d371-4308-923d-73139eef4951o%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/sequel-talk/CAPLYRqq_4NuiJcL-EVNVgsK75vj7B61N7_Omn%2BJ-RG20M0-R6A%40mail.gmail.com.
