On Fri, Apr 30, 2021 at 10:23 PM Jeremy Evans <[email protected]> wrote:
> On Fri, Apr 30, 2021 at 7:23 PM Chris Riddoch <[email protected]> wrote: > >> Hi, folks. >> >> As of SQLite 3.35.0 (2021-03-12), there's now support for the "returning" >> clause in insert, update, and delete statements, and it's designed >> (conveniently) on what Postgresql does. >> >> I'm sure this isn't quite as simple as adding an implementation of >> supports_returning? to lib/sequel/adapters/shared/sqlite.rb -- but I don't >> yet know what else is involved. It has the potential of affecting several >> plugins, and probably involves deeper knowledge of sequel's internals than >> I currently have. But I can read some code, of course. >> >> Jeremy, do you think this is something you'd like someone to take on as a >> patch, or would you rather do this yourself? I'm willing to give it a try, >> if you'd like. >> > > I was planning to add support for this and some other new stuff in SQLite > 3.35 in Sequel 5.45 (5.44.0 release is tomorrow). However, I'm always > happy to accept contributions. So if you want to work on this sometime in > the next two weeks, I'll be happy to wait until then. I can help if you > have any questions. There are already integration tests for the support, > so once you add supports_returning?, running rake spec_sqlite will test to > make sure everything works. > I haven't heard anything regarding this, so I'm planning on working on this starting tomorrow. If you've made any progress on this, please let me know. Thanks, Jeremy -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/sequel-talk/CADGZSSdwxiULLpWoO3DtMOxEJW9WZ5bk-A%2BLxhVSBnM9N7PH1A%40mail.gmail.com.
