Yes, i totally agree with you. we should not add a core class extension in sequel, maybe the correct way is extract those code into a individual gem, then add present? method, just like what i done. haha 在2021年8月4日星期三 UTC+8 下午11:12:54<Jeremy Evans> 写道:
> On Wed, Aug 4, 2021 at 7:49 AM Billy Zheng <[email protected]> wrote: > >> Oh, thank you. >> >> One more question, do you consider add support for `present?`, i wrote >> code like this at the end of that file. >> > > No. The only reason the blank extension exists is for backwards > compatibility. It was originally used for other internal features, but > Sequel::Database#blank_object? is now used for that (this will call blank? > on the object if the object responds to it, also for backwards > compatibility). I don't want to add any new features to the blank > extension. I also do not want to add any extensions that are general > modifications to core classes and not specifically related to Sequel. The > support for blank? was added before I took over maintenance. > > Thanks, > Jeremy > -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/sequel-talk/5372984f-2adc-4ba4-916a-b30d491d036en%40googlegroups.com.
