[ 
https://forge.continuent.org/jira/browse/SEQUOIA-812?page=comments#action_13628 
] 

Guillaume Smet commented on SEQUOIA-812:
----------------------------------------

Here is an additionnal patch which removes the strings of the query to be sure 
we don't count the semi-colon if it's in a string in requestNeedsExecute.

For example, SELECT * FROM mytable WHERE mycolumn='test ; test' should not need 
execute with this patch applied.

I use the same sort of code in pgFouine to normalize the queries and it seems 
to work well (note that you will have '''' if you have 'test''test' but it's 
not important in our cases).

It adds 2 regexps in the code path. I let you decide if it's worth it to fix 
this corner case.

--
Guillaume

> Sequoia may not store data records with semicolon
> -------------------------------------------------
>
>          Key: SEQUOIA-812
>          URL: https://forge.continuent.org/jira/browse/SEQUOIA-812
>      Project: Sequoia
>         Type: Bug
>   Components: JDBC Driver, CLI Console
>     Versions: Sequoia 3.0 beta2, Sequoia 3.0 beta1, Sequoia 2.10.4, Sequoia 
> 2.10.3, Sequoia 2.10.2, Sequoia 2.10.1, Sequoia 2.10
>     Reporter: Adnan Oeztuerk
>     Assignee: Emmanuel Cecchet
>      Fix For: Sequoia 2.10.5, Sequoia 3.0
>  Attachments: 812.RequestFactory.java.patch
>
>
> Sequoia throws an error message with the attempt a data record for storing 
> (insert or update), which contains a semicolon:
> ERROR: test.ConfigStoreException: *** SQLException occurred *** Message of 
> cause: Failed to execute request insert into table(name,description) VALUE.. 
> because of (org.continuent.sequoia.controller.requests.StoredProcedure)
> Example:
> insert into table(name,description) VALUES ('my name', 'Description with 
> semicolon; in varchar-attribute')

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   https://forge.continuent.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


_______________________________________________
Sequoia mailing list
[email protected]
https://forge.continuent.org/mailman/listinfo/sequoia

Reply via email to