Hi Pierre,

You can just check in the 'Version Control' tab of the issue to track the modifications. It will lead you to https://forge.continuent.org/plugins/scmcvs/viewcvs.php/sequoia/src/org/continuent/sequoia/controller/backup/BackupManager.java?root=sequoia&r1=1.10.2.2&r2=1.10.2.3

Don't worry, I have taken the idea but not the patch as is.

Thanks again for your feedback,
Emmanuel

Hi,

I do not know how to check fixed version, but given patch is buggy : when no 
server ip is configured --> NPE

You have to change ServerSocket soc = null;
    if (dumpServerIpAddress.indexOf(':')!=-1)
    {
      String [] tmpStrArr = dumpServerIpAddress.split(":");

by
    ServerSocket soc = null;
    if (dumpServerIpAddress!=null && dumpServerIpAddress.indexOf(':')!=-1)
    {
      String [] tmpStrArr = dumpServerIpAddress.split(":");

Regards

Pierre

-----Message d'origine-----
De : [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] la part de
Emmanuel Cecchet (JIRA)
Envoyé : 20 February 2008 13:25
À : [email protected]
Objet : [Sequoia] [JIRA] Commented: (SEQUOIA-830) Add port to Backuper
dumpServer specification


[ https://forge.continuent.org/jira/browse/SEQUOIA-830?page=comments#action_14277 ]
Emmanuel Cecchet commented on SEQUOIA-830:
------------------------------------------

I integrated the proposed fix in 2.10 branch. It works for me but please 
confirm that it also work for you,

Add port to Backuper dumpServer specification
---------------------------------------------

         Key: SEQUOIA-830
         URL: https://forge.continuent.org/jira/browse/SEQUOIA-830
     Project: Sequoia
        Type: Improvement

  Components: Backup System
    Versions: Sequoia 2.10.2
 Environment: All
    Reporter: Neil Aggarwal
    Assignee: Emmanuel Cecchet
 Attachments: SEQUOIA-830.txt


The Backuper options allows specification of a dump server IP address.  I would 
like to add the ability to specify the port as well.
Here is an example:
<Backup>
  <Backuper backuperName="postgres" className=
   "org.continuent.sequoia.controller.backup.backupers.
PostgreSQLSplitPlainTextBackuper" options="dumpServer=192.168.1.8,splitSize=500m"/>
</Backup>
We should be able to specify:
<Backup>
  <Backuper backuperName="postgres" className=
   "org.continuent.sequoia.controller.backup.backupers.
PostgreSQLSplitPlainTextBackuper" options="dumpServer=192.168.1.8:[PORT],splitSize=500m"/>
</Backup>
Thanks.



--
Emmanuel Cecchet - Research scientist
EPFL - LABOS/DSLAB - IN.N 317
Phone: +41-21-693-7558

_______________________________________________
Sequoia mailing list
[email protected]
https://forge.continuent.org/mailman/listinfo/sequoia

Reply via email to