Hi Andrew,
Thanks for the excellent report.
I have filed https://forge.continuent.org/jira/browse/SEQUOIA-1097
I have committed the fix in CVS HEAD for Sequoia 4.
Thanks for the feedback,
Emmanuel
I've just started looking at sequoia again, and have started using 2.10.10
It would appear that SEQUOIA-1029 has introduced a bug in
RecoveryLog.checkRecoveryLogConsistency
where the SQL for looking for open transactions used to be (2.10.9):
stmt = getDatabaseConnection().prepareStatement(
"SELECT * FROM " + getLogTableName() + " R1 WHERE R1."
+ getLogTableSqlColumnName() + " LIKE ? AND NOT EXISTS ("
+ "select transaction_id FROM "
+ getLogTableName() + " R2 WHERE "
+ " R1.transaction_id = R2.transaction_id AND (R2."
+ getLogTableSqlColumnName()
+ " = ? OR R2." + getLogTableSqlColumnName() + " = ?) ) ");
with params BEGIN%, COMMIT, ROLLBACK
it's now:
stmt = getDatabaseConnection().prepareStatement(
"SELECT transaction_id FROM " + getLogTableName() + " r1 WHERE r1."
+ getLogTableSqlColumnName()
+ " LIKE ? AND NOT EXISTS (SELECT transaction_id FROM "
+ getLogTableName()
+ " r2 WHERE r1.transaction_id=r2.transaction_id AND (r1."
+ getLogTableSqlColumnName() + " LIKE ? OR r2."
+ getLogTableSqlColumnName() + " LIKE ?))");
However, note that in the OR bit:
(r1." + getLogTableSqlColumnName() + " LIKE ? OR r2." + getLogTableSqlColumnName() +
" LIKE ? )
the first table name has become r1 where it was & ought to be r2.
the effect of which is that when I bring up sequoia, I get a warning in my log for
every transaction that was committed, saying it wasn't completed & a rollback
has been added to the recovery log. As these are presumably committed before
rollback upon recovery, I don't think it has any actual impact apart from a large
amount of spurious logging...
Many thanks,
Andrew Lawrenson
_______________________________________________
Sequoia mailing list
[email protected]
https://forge.continuent.org/mailman/listinfo/sequoia
--
Emmanuel Cecchet
FTO @ Frog Thinker
Open Source Development & Consulting
--
Web: http://www.frogthinker.org
email: [EMAIL PROTECTED]
Skype: emmanuel_cecchet
_______________________________________________
Sequoia mailing list
[email protected]
https://forge.continuent.org/mailman/listinfo/sequoia
