I got the proposal for SMTPACL and generally think it's very sound. I like the idea of using the mailet API, with certain restrictions.

There are two things I would suggest changing:
1. The name. ACL doesn't make sense as this isn't a list of anything. This is specific to SMTP, and in fact I might make it a bit more specific to SMTP...
2. The class/state structure. You need to be sure that both mailets AND matchers are aware that this is during an SMTP transaction and we do not have a MimeMessage. So I would do two changes:
a. class-wise, make an interface (probably empty interface) that declares that this matcher and mailet can be used in the <rcpt> tag, i.e., they don't care about the MimeMessage.
b. state-wise, just use the existing state/errorMessage fields. Instead of SMTPAccept, you just leave getState() as Mail.DEFAULT. Instead of SMTPReject, you do setState(Mail.ERROR) and setErrorMessage("550 cannot find MX for your domain").


--
Serge Knystautas
President
Lokitech >> software . strategy . design >> http://www.lokitech.com
p. 301.656.5501
e. [EMAIL PROTECTED]


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to