On Tuesday 13 April 2004 03:49, Noel J. Bergman wrote: > > I haven't looked at the org.xbill.DNS.Address but it > > sounds like a good solution. > > Agreed. I'll look at making that change. > > > I have put it on my todo-list to go through the code and > > weed-out InetAddress, just haven't gotten around to it yet. > > I just did: > > $ grep --recursive "InetAddress\.get.*ByName" src/java/ -l > src/java/org/apache/james/James.java > src/java/org/apache/james/core/AbstractJamesService.java > src/java/org/apache/james/dnsserver/DNSServer.java > src/java/org/apache/james/fetchmail/MessageProcessor.java > > src/java/org/apache/james/transport/mailets/RemoteDeliverySocketFactory.jav >a src/java/org/apache/james/transport/mailets/RemoteDelivery.java > src/java/org/apache/james/transport/matchers/InSpammerBlacklist.java > src/java/org/apache/james/util/NetMatcher.java > > James, AbstractJamesService, and RemoteDeliverySocketFactory were all local > stuff. > > I've updated DNSServer, MessageProcessor, RemoteDelivery, > InSpammerBlacklist, and NetMatcher it use org.xbill.DNS.Address for the two > static methods. I fully qualified the name to (a) make it easier to find, > and (b) because it was necessary in some cases to distinguish from > javax.mail.Address, anyway. Of course, I just realized that like an idiot, > I just committed the changes before testing them. :-( I'll be doing that > immediately.
Sounds great, (except for the non-testing part ;-)) > > Another side-effect of the changes since yours and Richard's is that by > passing an IP address to JavaMail, we eliminate its lookup, which would > also have used InetAddress' caching. Yes, I was aware of that "sideeffect". > > I find it bothersome that Sun's DNS service for JNDI apparently ignores the > TTL provided by the DNS server. Agreed, the Sun is absolutely NOT geared towards a mail-server solution, and their reason for the "cache-forever" srategy (that it is made to prevent spoofing attacks) is IMO a bit farfetched, the very least they could have done was to provide a hook to circumvent it. But as it is we are not too pleased with their JavaMail implementation either ;-) --Søren > > --- Noel > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] -- Søren Hilmer, M.Sc. R&D manager Phone: +45 70 27 64 00 TietoEnator IT+ A/S Fax: +45 70 27 64 40 Ved Lunden 12 Direct: +45 87 46 64 57 DK-8230 Åbyhøj Email: soren.hilmer <at> tietoenator.com --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
