Thoughts? Has anyone other than Danny had time to look at the reverse path
handling changes?


If I understood correctly, the new behaviour is never adding a Return-Path header except during local delivery, and have getSender() == null being the only test done throughout the code.
Looking at the code, it seems all OK.

IMHO we should remove the org.apache.james.transport.mailets.AbstractRedirect#getExistingReturnPath(Mail mail) method as it becomes misleading and is no longer used (at least in the official code - being protected it could be used by a mailet subclass somewhere, but it is very unlikely).

The same for org.apache.james.core.MailImpl#getReturnPath(MimeMessage message), that is also inconsistent with getExistingReturnPath(Mail mail) above. Being private, there should no problem at all to remove it.

Vincenzo

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

Reply via email to