Mike,
Had a chance to review the code briefly. It does look simpler, and it's definitely nice to see less stream wrapping logic. Couple of questions about MINA/SMTP impl:
1. Line feeds... it seems the protocol handler is all line feed based, so:
a. if client is sending crlf or lf, what impact does that have?
b. when we're in DATA mode, could I potentially corrupt data by converting crlf to lf or vice versa?
c. size limit... it seems that if I sent data without a linefeed (i.e., ababababababababababababab...), I would never complete a line and hit the check for size limit... where is this buffer happening?
2. Command impls... I saw you inlined all the commands into the SMTP handler class... was this just done for simplicity, and would you see any downside to splitting each command into its own class? The benefit would be smaller classes and more flexibility.
3. Configuration... I didn't look into how you configure this, but how hard do you think it would be to take the current James SMTP configuration and instantiate this MINA SMTP impl?
4. TLS support... I saw an example of how MINA does SSL, but is there a way to support SMTP's SSL feature of "upgrading" to SSL after we've already been exchanging data with the client in plaintext? I'm not explaining this well, but hopefully you know what I mean.
-- Serge Knystautas Lokitech >> software . strategy . design >> http://www.lokitech.com p. 301.656.5501 e. [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
