[ http://issues.apache.org/jira/browse/JAMES-437?page=comments#action_12363816 ]
Stefano Bagnara commented on JAMES-437: --------------------------------------- The provided patch is not reentrant. Please keep in mind that CmdHandlers must be Thread Safe. You should remove the 2 added fields because they add state to the CmdHandler and the state would be shared between threads. Furthermore when recipientAddress = new MailAddress(recipient); throw an exception you keep the old value in the field so the logging would contain the bad address. > add failed recipient address to log when authorization fails > ------------------------------------------------------------ > > Key: JAMES-437 > URL: http://issues.apache.org/jira/browse/JAMES-437 > Project: James > Type: New Feature > Components: SMTPServer > Reporter: Amichai Rothman > Priority: Trivial > Attachments: JAMES-437.full.patch, JAMES-437.patch > > when an attempt to relay a message not intended for a local domain the > following message is logged: > "Rejected message - authentication is required for mail request" > In this, and other similar error cases, it would be quite useful to append > the actual failed recipient address to the log so that one can tell not only > that an error had occured, but also why and by whom... > Adding such simple useful information to logs (this and others) can make it > much easier to diagnose delivery issues, rather than having a red light light > up on the dashboard but not knowing what's wrong with the car (as the well > known MS GPF story goes...) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
