> + responseString = "501 Ehlo can not resolved";
Shouldn't that be EHLO? A bit too aggressive on the case folding?
Personally, I think that it ought to be all upper case everywhere, since that
is the name of the command in the specification, but certainly in emitted text.
And, while on the subject of log messages, at pet peeve of mine, this one
should stand for all similar ones that are bad (in my view). Look at the
message:
+ responseString = "501 Ehlo can not resolved";
+ session.writeResponse(responseString);
+ getLogger().info(responseString);
Minorly, it is the name passed to EHLO that cannot be resolved, but more
importantly, we should log the name that could not be resolved.
At some point, we should audit our logging to be more consistent, and to make
sure that we are providing the right level of diagnostic information in the
messages.
--- Noel
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
