Noel J. Bergman wrote:
The intent -- at least from some of us -- for the handler chain was not to
keep adding features into core handlers, but to add additional handlers. So
far, I keep seeing more optional features added to core handlers.
Comments?
I applied the following patches:
1) HELO/EHLO domain name check
2) RCPT count limit
3) RCPT tarpit support
I applied them in the basic commands because:
- they are almost standard behaviour
- they are not "business specific"
- the code involved is 10-20 line of code.
- the default behaviour is unchanged
I thought that creating multiple optional handlers would have been code
duplication and more difficult to mantain in those cases.
E.g: I would not have committed the "Add Greylist support" stuff in the
standard components, as I did with custom mailet submitted to JIRA about
antivirus integration and similar things.
We should decide what to do with additional mailets/matcher/handlers in
general: we currently don't have a repository and a website where to
publish those additional stuff but we can't continue adding each new
mailet to the james core.
When custom handler/mailets/matcher need third party software to work or
additional libraries I would prefer to have them published in a
different subproject.
Stefano
PS: I expect that other committers review the commits descriptions and
the related JIRA issues and I can revert any commit if needed. I though
this "optimistic" workflow is faster than voting for each single commit.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
